[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support splitting SOURCE in multiple rmk files
From: |
Robert Millan |
Subject: |
Re: [PATCH] Support splitting SOURCE in multiple rmk files |
Date: |
Wed, 24 Jun 2009 22:53:37 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Jun 24, 2009 at 08:13:35PM +0800, Bean wrote:
> >> +bin_UTILITIES += grub-mkelfimage
> >> +grub_mkelfimage_SOURCES = util/resolve.c
> >> +
> >> pkglib_MODULES += cpuid.mod
> >> cpuid_mod_SOURCES = commands/i386/cpuid.c
> >> cpuid_mod_CFLAGS = $(COMMON_CFLAGS)
> >
> > This looks very confusing. If what is actually doing is append a new
> > string to the grub_mkelfimage_SOURCES variable, why not with "+=" ?
> >
> > "=" means override the previous value.
>
> Hi,
>
> You can use = or +=, actually the macro is used by genmk.rb to
> generate the rules, it's not used by Makefile itself, so no problem
> overriding it.
Yes, but using = to generate a rule that actually means += is very confusing.
Please don't do that.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
- [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Robert Millan, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/24
- Re: [PATCH] Support splitting SOURCE in multiple rmk files,
Robert Millan <=
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/25
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/25
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/26
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Bean, 2009/06/26
- Re: [PATCH] Support splitting SOURCE in multiple rmk files, Pavel Roskin, 2009/06/26