grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/18] Simplify sed script and make awk script more robust


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH 4/18] Simplify sed script and make awk script more robust
Date: Tue, 16 Jun 2009 12:34:04 +0200



On Tue, Jun 16, 2009 at 2:59 AM, Pavel Roskin <address@hidden> wrote:
On Sat, 2009-05-30 at 16:44 +0200, Vladimir 'phcoder' Serbinenko wrote:
> sed on apple's platform is more limited here is workaround. awk needs
> a check not to make module depend on itself in some cases

Sorry for not being able to review this series earlier.  This patch
doesn't seem to be properly explained.  It's not clear is you are
simplifying the _expression_ without loss in functionality or you chose to
ignore some cases.
I simplify without the loss of functionality. First simplification is to split a sed _expression_ using (*|*) construction into two expressions and the second is not to care about trailing /. Even if it's nicer to avoid double / in filenames I believe it isn't a problem for any system


--
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel



--
Regards
Vladimir 'phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]