Re: [PATCH] more scripting fixes

[Vladimir 'phcoder' Serbinenko]

On Sat, Jun 13, 2009 at 12:10 AM, Pavel Roskin<address@hidden> wrote:
> On Wed, 2009-06-10 at 12:52 +0200, Vladimir 'phcoder' Serbinenko wrote:
>> +       Fix handling of string like \"hello\" and "a
>> +       b"
>> +
>> +       * script/sh/lexer.c (check_textstate): accept
>> GRUB_PARSER_STATE_ESC
>> +       (grub_script_yylex): fix parsing of quoting, escaping and
>> newline
>
> I needed to tweak the patch and remove a trivial chunk from it to make
> it apply to the current sources.  The adjusted patch is attached.
> ChangeLog entries should not be part of the patch.
Thank you for rediff but it wasn't really necessary. As for changelog
I don't see for it creates problems for anyone since I commit my
patches myself and for testing this reject doesn't hurt anyway
> But something is still wrong:
>
> grub:sh > echo "a\"b""
> a\b
> grub:sh > echo "a\"b''c
> a\bc
>
> It looks like \" cancels quoting for the subsequent characters, but it
> shouldn't.
Actually the problem is different: escaping in quoting isn't parsed at
all. For first step lexer uses rescue mode parser which isn't that
easy to extend compactly. I think that we should leave rescue mode
parser as it is now and put a better first-step parser in sh.mod. I'll
do it when my todo list scrols to this point
>
> --
> Regards,
> Pavel Roskin
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko