Re: multiboot take partial mmap

[Vladimir 'phcoder' Serbinenko]

On Thu, Jun 4, 2009 at 10:07 PM, Andrey Valyaev<address@hidden> wrote:
> On Четверг 04 июня 2009 03:18:15 Vladimir 'phcoder' Serbinenko wrote:
>> > My kernel worked fine with grub-legacy.
>> > But encounter problem.
>> > kernel receive mmap up to 1meg...
>> Be sure to use latest svn and post your exact config
>> since I didn't have such a problem in my tests
>
> Sorry, it's my bug...
> grub2 place modules to upper pages, but grub-legasy place modules after
> kernel.
>
> I wrong check the modules location for searching temporary kernel memory.
>
> mmap work.
Do you mean that memory map as passed by mainstream grub is ok?
>
> Some question. Module mmap need only for command badram?
No. It's needed for drivemap and ACPI spoofing too
> my loader worked
> without mmap module.
Do you mean that you replaced grub_memory_mmap_iterate with
grub_machine_memory_mmap_iterate? As I already said it's NOT correct.
Can you give me more details in a personal mail in Russian so language
wouldn't be a problem for you?
>
> PS: latest svn revision (from 2243) failed with message:
>
> gcc -Icommands -I./commands -I. -I./include -I./include -Wall -W  -Wall -W -
> Wshadow -Wpointer-arith -Wmissing-prototypes                  -Wundef -
> Wstrict-prototypes -g -Os -falign-jumps=1 -falign-loops=1 -falign-functions=1
> -m32 -fno-stack-protector -mno-stack-arg-probe -fno-builtin -mrtd -mregparm=3
> -m32 -Werror -Wall -MD -c -o search_mod-commands_search.o commands/search.c
> cc1: warnings being treated as errors
> commands/search.c: In function 'search_fs':
> commands/search.c:42: error: generating trampoline in object (requires
> executable stack)
> commands/search.c: In function 'grub_cmd_search':
> commands/search.c:105: error: generating trampoline in object (requires
> executable stack)
> make[1]: *** [search_mod-commands_search.o] Error 1
>
> $ gcc --version
> gcc (Gentoo 4.3.3-r2 p1.1, pie-10.1.5) 4.3.3
>
This is because of commit 2243 by Robert Millan. The commit was about
floppy probing but also added -Wall -Werror to search.mod
I myself stepped on this mine once with adding -Wall -Werror to my xnu module.
I'll revert this change (only -Werror, not the rest of commit) as it
causes build error for all gentoo users. Sorry, Robert, but we can't
enable -Werror and still have nested functions. I don't think we
should use -Werror at all because different compilers, versions or
modifications of same compiler cause different warnings and imho
maintaintaining cost is too high and breaks are too frequent. Or
perhaps we can enable -Werror only on some compilers? Or perhaps
anyone has a better idea
> --
> Andrey Valyaev
> http://mdf-i.blogspot.com
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko