[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix grub-setup on kfreebsd by adding 0x10 to the sysctl ("ke
From: |
Robert Millan |
Subject: |
Re: [PATCH] fix grub-setup on kfreebsd by adding 0x10 to the sysctl ("kern.geom.debugflags") flags |
Date: |
Mon, 13 Apr 2009 16:49:02 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Apr 13, 2009 at 04:26:19PM +0200, Felix Zielcke wrote:
> +#ifdef __FreeBSD_kernel__
Unfortunately FreeBSD doesn't define __FreeBSD_kernel__, so we need
to check for both macros.
> +#if defined __FreeBSD_kernel__
> + int sysctl_flags, sysctl_oldflags;
> + size_t sysctl_size = sizeof (sysctl_flags);
You can add a `const' on this one.
> + sysctl_flags = sysctl_oldflags |= 0x10;
Shouldn't this be "sysctl_oldflags | 0x10" ?
Btw you can avoid the two subsequent calls if sysctl_flags == sysctl_oldflags.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."