Re: [BUGFIX]

[phcoder]

rgrep revealed no use for the second kernel_elf_HEADERS, so I propose to 
remove it altogether
Is everybody comfortable with this patch? If I hear no oppositions in 
couple of days I'll commit it.
phcoder wrote:
> Is kernel_elf_HEADERS used for anything else than symlist.c and 
> kernel-symlist,lst generation?
> Manoel Rebelo Abranches wrote:
> > symlist.c is generated by  gensymlist.sh script so only the patch for
> > conf/powerpc-ieee1275.rmk is really necessary.
> >
> > On Thu, 2009-04-02 at 16:48 +0200, phcoder wrote:
> > > Bean wrote:
> > > > On Thu, Apr 2, 2009 at 8:52 PM, phcoder <address@hidden> wrote:
> > > > > Hello symbols from command.h aren't exported correctly. Here's a 
> > > > > bugfix. It
> > > > > compiles with it but I haven't checked yet if compiled binary 
> > > > > works. Can
> > > > > someone familiar with build system have a look at this?
> > > > Hi,
> > > >
> > > > It's a little wired, why would powerpc-ieee1275.rmk has two
> > > > kernel_elf_HEADERS in the first place ?
> > > I have no idea, I was hoping that someone more familiar with build 
> > > system could tell me why it's done so


--

Regards
Vladimir 'phcoder' Serbinenko

diff --git a/ChangeLog b/ChangeLog
index 8532741..61279fa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-04-03  Vladimir Serbinenko  <address@hidden>
+
+       * conf/powerpc-ieee1275 (kernel_elf_HEADERS): add list.h and command.h
+       remove suplicate kernel_elf_HEADERS
+
 2009-04-01  Pavel Roskin  <address@hidden>
 
        * Makefile.in: Remove all references to MODULE_LDFLAGS, it's
diff --git a/conf/powerpc-ieee1275.rmk b/conf/powerpc-ieee1275.rmk
index 5aaaf56..9ba2981 100644
--- a/conf/powerpc-ieee1275.rmk
+++ b/conf/powerpc-ieee1275.rmk
@@ -16,7 +16,8 @@ DEFSYMFILES += kernel_syms.lst
 kernel_elf_HEADERS = boot.h cache.h device.h disk.h dl.h elf.h elfload.h \
        env.h err.h file.h fs.h kernel.h misc.h mm.h net.h parser.h rescue.h \
        symbol.h term.h time.h types.h powerpc/libgcc.h loader.h partition.h \
-       pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h
+       pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h list.h \
+       command.h
 
 symlist.c: $(addprefix include/grub/,$(kernel_elf_HEADERS)) config.h 
gensymlist.sh
        /bin/sh gensymlist.sh $(filter %.h,$^) > $@ || (rm -f $@; exit 1)
@@ -87,8 +88,6 @@ kernel_elf_SOURCES = kern/powerpc/ieee1275/startup.S 
kern/ieee1275/cmain.c \
        kern/parser.c kern/partition.c kern/env.c kern/powerpc/dl.c     \
        kern/generic/millisleep.c kern/time.c                            \
        symlist.c kern/powerpc/cache.S
-kernel_elf_HEADERS = grub/powerpc/ieee1275/ieee1275.h list.h handler.h \
-       command.h
 kernel_elf_CFLAGS = $(COMMON_CFLAGS)
 kernel_elf_ASFLAGS = $(COMMON_ASFLAGS)
 kernel_elf_LDFLAGS = $(COMMON_LDFLAGS) -static-libgcc -lgcc \