Re: ELF bugfixes

[David Miller]

From: phcoder <address@hidden>
Date: Thu, 12 Mar 2009 09:23:34 +0100

> Index: include/grub/elf.h
> ===================================================================
> --- include/grub/elf.h        (revision 2036)
> +++ include/grub/elf.h        (working copy)
> @@ -77,7 +77,7 @@
>    Elf32_Half e_shentsize;            /* Section header table entry size */
>    Elf32_Half e_shnum;                /* Section header table entry count */
>    Elf32_Half e_shstrndx;             /* Section header string table index */
> -} Elf32_Ehdr;
> +} __attribute__ ((packed)) Elf32_Ehdr;
>  

There is no reason why you should need the packed attribute here.

I can't think of any cpu where this could even remotely be necessary.
And if it's not necessary, all it does it emit terribly suboptimal
code on RISC cpus.