Re: [PATCH] linux/gfxterm integration

[Vesa Jääskeläinen]

Robert Millan wrote:
> On Fri, Mar 06, 2009 at 08:57:35PM +0100, Robert Millan wrote:
>> This patch integrates the generic Linux loader with gfxterm.  The result is
>> that graphical mode becomes usable with this loader.  Our loader gets the
>> screen settings from the video subsystem (as per gfxterm setup), and passes
>> them to Linux.
>>
>> This way GRUB/gfxterm can transition to Linux/fb with no further mode
>> setting.  Perhaps this can be exploited to make the transition seamless
>> by using the same background image in both places, but I haven't explored
>> this possibility yet :-)
>>
>> Note: As the comment in grub/video.h says, struct grub_video_render_target
>> didn't really want to be moved.  My code only needs to access it to find
>> the framebuffer address.  Perhaps it'd be better to move this information
>> elsewhere?  Or split it in a separate structure / getter?
> 
> New patch.  This one calls grub_linux_setup_video() from grub_linux32_boot
> instead of grub_rescue_cmd_linux.  This way it gets the video status we have
> when "boot" is issued instead of the one we have when linux is loaded.
> 
> Any comments on my question about struct grub_video_render_target ?

Don't like em... Let me think it a bit.