Re: [PATCH] Support up to 256 SCSI disks on Linux

[Robert Millan]

On Wed, Mar 04, 2009 at 04:35:09PM +0000, Colin Watson wrote:
> Linux's Documentation/devices.txt file says that up to 256 SCSI disks
> are supported. GRUB currently only supports the first 16. Wikimedia
> filed an Ubuntu bug report about this
> (https://bugs.launchpad.net/bugs/335174), so here's a patch to extend
> this. (I really haven't been able to test this much at all beyond
> compile-testing as I don't have a suitable system myself ...)
> 
> I suppose it might be nice to macroify the stuff in
> grub_util_getdiskname, but TBH I'm not sure it would shorten it all that
> much or make it much more readable, so I didn't bother.

Hi Colin,

I feel some dejavu.  I think this is not the first max disk limit you
find ;-)

>    else if (major == SCSI_DISK0_MAJOR)
> -    sprintf (name, "/dev/sd%c", 'a' + minor / 16);
> +    grub_util_getdiskname_scsi (name, 0, minor / 16);
> +  else if (major == SCSI_DISK1_MAJOR)
> +    grub_util_getdiskname_scsi (name, 1, minor / 16);
> [...]

Can this be factorized somehow?  Space in raid.mod is quite critical; when
used it usually ends up in core.img, which needs to fit in the embed area.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."