grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer


From: Yoshinori K. Okuji
Subject: Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer
Date: Tue, 25 Nov 2008 22:17:17 +0100
User-agent: KMail/1.9.9

On Saturday 22 November 2008 16:35:09 Robert Millan wrote:
> When an error is detected by ata.mod during drive scan, it will pass it to
> the upper layer.  This results in GRUB aborting when trying to enter normal
> mode, even if the error is not critical (e.g. affects a drive not used
> during boot).
>
> There are a number of places in ata.mod where these errors could be
> handled, so I'm not sure if my proposed change would be the best approach. 
> Some comment would be appreciated.

This is one way, but I think the upper layer should be more robust against 
errors raised from modules. For example, we can unload a module, and clear 
GRUB_ERRNO, if the init function in this module return an error.

Regards,
Okuji




reply via email to

[Prev in Thread] Current Thread [Next in Thread]