Re: [PATCH] GSoC #01 grub-mkrescue i386-pc multiple overlays

[Robert Millan]

On Sat, Aug 30, 2008 at 11:43:41PM -0700, Colin D Bennett wrote:
> === modified file 'util/i386/pc/grub-mkrescue.in'
> --- util/i386/pc/grub-mkrescue.in     2008-07-12 14:40:50 +0000
> +++ util/i386/pc/grub-mkrescue.in     2008-08-30 18:33:46 +0000
> @@ -71,7 +71,7 @@
>      --modules=*)
>       modules=`echo "$option" | sed 's/--modules=//'` ;;
>      --overlay=*)
> -     overlay=`echo "$option" | sed 's/--overlay=//'` ;;
> +     overlay=${overlay}${overlay:+ }`echo "$option" | sed 's/--overlay=//'` 
> ;;
>      --pkglibdir=*)
>       input_dir=`echo "$option" | sed 's/--pkglibdir=//'` ;;
>      --grub-mkimage=*)
> @@ -124,9 +124,10 @@
>    echo "insmod $i"
>  done > ${aux_dir}/boot/grub/grub.cfg
>  
> -if test "x$overlay" = x ; then : ; else
> -  cp -dpR ${overlay}/* ${aux_dir}/
> -fi
> +for d in ${overlay}; do
> +  echo "Overlaying $d"
> +  cp -dpR "${d}"/* "${aux_dir}"/
> +done
>  
>  if [ "x${image_type}" = xfloppy -o "x${emulation}" = xfloppy ] ; then
>    # build memdisk

Hi,

I'd suggest mentioning in --help that --overlay can be specified multiple
times.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."