Re: [PATCH] skip over invalid BSD partitions

[Marco Gerards]

Felix Zielcke <address@hidden> writes:

> On invalid BSD partitions partmap/pc.c stops with reading the partitons,
> so grub doestn't know anything about the ones behind it.
> Attached patch fixes this and displays also the partition number not
> only the invalid magic it encounters
>
> 2008-07-31  Felix Zielcke  <address@hidden>
>
>         * partmap/pc.c (pc_partition_map_iterate): Skip over invalid BSD 
> partitions
>       or if there's no space for the disk label and print the partition 
> number on a 
>       invalid magic

When does this occur?

> Index: partmap/pc.c
> ===================================================================
> --- partmap/pc.c      (Revision 1753)
> +++ partmap/pc.c      (Arbeitskopie)
> @@ -160,9 +160,11 @@
>               {
>                 /* Check if the BSD label is within the DOS partition.  */
>                 if (p.len <= GRUB_PC_PARTITION_BSD_LABEL_SECTOR)
> -                 return grub_error (GRUB_ERR_BAD_PART_TABLE,
> -                                    "no space for disk label");
> -
> +                 {
> +                   grub_error (GRUB_ERR_BAD_PART_TABLE,
> +                               "no space for disk label");
> +                   continue;
> +                 }

If you continue as no error occured, why do you throw an error?

--
Marco