Re: [PATCH] Fix chainloding + Chainloading into logical partitions

[Bean]

On Thu, Jul 10, 2008 at 10:08 PM, Lucas Gadani <address@hidden> wrote:
> On Sun, Jul 6, 2008 at 5:47 PM, Lucas Gadani <address@hidden> wrote:
>> On Sun, Jul 6, 2008 at 18:41, Robert Millan <address@hidden> wrote:
>>>
>>> Looks like it increases pc.mod code to store information that is only useful
>>> to the chainloader.  Is there a reason for not having the chainloader
>>> retrieve it?  (note that for disk access we have a cache)
>>
>> We would need to duplicate the code that iterates through the logical
>> partitions in the chainloader or we can change
>> pc_partition_map_iterate hook function to also receive
>> grub_pc_partition (we can't use the pc_partition_map_iterate cause the
>> hook function only receives a grub_disk_t and grub_partition_t, but
>> not the grub_pc_partition that's necessary to reconstruct the
>> partition info).
>
> What would be the best patch to get accepted into grub? I'm willing to
> code the patch, but first I'd like to know the best way to get
> comitted to grub.

Hi,

I don't know how many fields of partition table is actually used by
syslinux. But from your code, I get the sense that only the start
sector is used. If that's the case, there is no need to save the
partition entry, we can just set the value in chainloader.

-- 
Bean