Re: [PATCH] Remote GDB debugging stub (for i386)

[Lubomir Rintel]

On Tue, 2008-05-06 at 17:02 +0200, Robert Millan wrote:
> On Thu, May 01, 2008 at 03:12:25PM +0200, Lubomir Rintel wrote:
> > --- grub2/gdb/cstub.c       1970-01-01 01:00:00.000000000 +0100
> > +++ grub2-gdb/gdb/cstub.c   2008-05-01 10:57:57.000000000 +0200
> > @@ -0,0 +1,362 @@
> > +/* cstub.c - machine independent portion of remote GDB stub */
> > +/*
> > + *  Copyright (C) 2006  Lubomir Kundrak
> 
> Please put the FSF in copyright notice (since copyright is being assigned).
> 
> Also acknowledge whatever copyright/license notice there was in code copied
> from gdb (though if it was public domain, I think you can skip the latter).

Done.

> Please update to GPL 3.  I suggest you copy the whole blob since there are
> improvements in the last paragraph.

Done

> >  /* The size of the first region which won't be compressed.  */
> > -#define GRUB_KERNEL_MACHINE_RAW_SIZE               0x4A0
> > +#define GRUB_KERNEL_MACHINE_RAW_SIZE               0x4BC
> 
> What caused this?   Any way we can have this dynamically calculated?

Described in the changelog. No idea how could it be calculated, I just
remember Okuji suggesting number  that value to me when I was trouble
loading IDT.
 
-- 
Lubomir Rintel (Was: Kundrak)
http://v3.sk/~lkundrak/