grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] PNG image reader


From: Bean
Subject: Re: [PATCH] PNG image reader
Date: Tue, 29 Jan 2008 17:45:50 +0800

On Jan 29, 2008 5:10 PM, Marco Gerards <address@hidden> wrote:
> Bean <address@hidden> writes:
>
> > add two sanity check, one for chuck size, make sure the on disk
> > structure is correct, one for raw image, make sure the image won't
> > overflown. also adjust a few macro names and the filter handling code.
> >
> >       * conf/i386-pc.rmk (pkglib_MODULES): Add `png.mod'.
> >       (png_mod_SOURCES): New variable.
> >       (png_mod_CFLAGS): Likewise.
> >       (png_mod_LDFLAGS): Likewise.
> >
> >       * video/readers/png.c : New file.
>
> Can you please include the header for the changelog entry?  It's
> minor, but it prevents some confusion at my side.
>
> One small comment below.  Can you fix this before you commit? :-)

Fixed and committed.

-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]