[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compiling grub2 on *BSD?

From: Robert Millan
Subject: Re: Compiling grub2 on *BSD?
Date: Mon, 28 Jan 2008 11:47:50 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

> > -       movsbl  %dh, %eax
> > -       movl    %eax, %ss:(DATA_ADDR + GRUB_KERNEL_MACHINE_INSTALL_DOS_PART)
> > +       // Check for the multiboot signature
> > +       cmpl    $0x1badb002, %ss:(DATA_ADDR + 0x50)
> > +       jz      1f
> [...]
> if there is no objection, I'd like to check in this patch.

I don't like that you hardcode 0x1badb002.  Could you use the macro from
multiboot.h ?

Also for the comments, I think /* */ is preferred (at least, it is consistent
with the rest of GRUB).

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]