[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Don't abort if prefix is not set

From: Pavel Roskin
Subject: Re: [PATCH] Don't abort if prefix is not set
Date: Sat, 26 Jan 2008 15:11:02 -0500
User-agent: Internet Messaging Program (IMP) H3 (4.1.4)

Quoting Robert Millan <address@hidden>:

+  if (! grub_dl_dir) {
+    grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set");
+    return 0;

Seems fine, but are you sure this error is handled somewhere?

If prefix is not set, the module is not loaded. What other handling do we need?

I found that prefix would not be set on PowerPC if /memory/available is missing. Even though I have a better workaround for it now, I still think that aborting for such minor reason is wrong. After all, the user may unset prefix.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]