[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memdisk plus lnxboot extension

From: Robert Millan
Subject: Re: [PATCH] memdisk plus lnxboot extension
Date: Tue, 22 Jan 2008 17:51:52 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Jan 23, 2008 at 12:22:32AM +0800, Bean wrote:
>       * util/i386/pc/grub-mkimage.c (generate_image) : Add is_linux parameter.
>       If it's set, use lnxboot.img as header instead of diskboot.img.
>       (options): Add "linux"|'x' option
>       (main): Parse --linux|-x option, and pass its value to generate_image.

I don't like this very much.  We don't have grub-mkimage options to concatenate
it with boot.img, so why with lnxboot.img ?

Also, I can only think of very specific situations in which this interface
would be useful (that is, when firmware has only a linux loader).  It makes
sense to me as a compatibility layer, yes.

But it seems you want it as a general-purpose option; for that, why not make
it saner like multiboot?  I don't think it's a good idea to compromise our
boot semantics because of the ones legacy Linux has.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]