[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] enable multiboot2 loader on i386-ieee1275

From: Robert Millan
Subject: Re: [PATCH] enable multiboot2 loader on i386-ieee1275
Date: Mon, 21 Jan 2008 12:20:51 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Jan 21, 2008 at 08:13:36AM +0100, Torsten Duwe wrote:
> On Monday 21 January 2008, Robert Millan wrote:
> > This makes multiboot2 work on i386-ieee1275.  Tested both with elf32 and
> > elf64 images.
> > grub2/loader/powerpc/ieee1275
>                ^^^^^^
> > #elif defined(__i386__)
> NAK.
> Please do not commit that. It's a nice hack I can try, but the real solution 
> needs cleanup! Once you start serious Open Firmware support for x86, ieee1275 
> must not reside beneath PPC any longer. BTW sparc has OFW, too.

This file needs to move.  There's nothing powerpc-specific about it, really,
other than this line.  Writing new files or duplicating code when there's no
reason to, leads to bitrot.  This happened to the sparc64 port, and I want to
avoid it.

What I had in mind is getting the i386-ieee1275 port fully functional, and then
move the files that are in powerpc/ directories to their corresponding
ieee1275/ ones.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]