[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] improve grub_mm_init_region() debug message

From: Robert Millan
Subject: Re: [PATCH] improve grub_mm_init_region() debug message
Date: Tue, 15 Jan 2008 19:00:55 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote:
> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote:
> > -  grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n",
> > addr, (unsigned int) size);
> > +  grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n",
> > addr, addr + size);
> Maybe addr+size-1 would be better?  Inclusive boundaries are more
> intuitive.  Just run "cat /proc/iomem" to see what I mean.

Sounds better to me.

Does this change (with addr + size -1) sound fine to everyone else?

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]