[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix endianess in IEEE-1275 integer properties

From: Pavel Roskin
Subject: Re: [PATCH] fix endianess in IEEE-1275 integer properties
Date: Mon, 14 Jan 2008 09:20:39 -0500

On Sun, 2008-01-13 at 21:30 +0100, Robert Millan wrote:
> Integer properties are always in big endian.  This (incomplete) patch is my
> suggested approach to deal with this.  I'd like to receive input about it
> before I complete it (checking all calls to grub_ieee1275_get_property
> through GRUB and replacing with grub_ieee1275_get_integer_property when
> appropiate).
> Again, some testing on Apple/IBM/Genesi hardware would be nice.

It doesn't apply cleanly, and I don't see how the result of
grub_ieee1275_get_integer_property() is used.  I suggest that you go
ahead with the changes as long as you get them right for your platform.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]