[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

From: Christian Franke
Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check
Date: Tue, 01 Jan 2008 19:03:36 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070802 SeaMonkey/1.1.4

Robert Millan wrote:
This part is intended to handle the (normal) case of one continuous region with not gap between 1M and 16M:
(0x3C00 << 10) = 0x100000 * 15 = 15M
But this part does not work due to the same bug.

It is IMO not necessary to make this distinction. The function compact_mem_regions() called a few lines later joins the two regions anyway.

Ah, ok.  Have you verified that this is so?  (setting debug=mem variable
during init might help on that).

Yes. During testing, I temporarily added some diagnostic output. The function compact_mem_regions() works as expected.

Sorry for being so inquisitive, but I need to understand things well before
touching this part of GRUB, which as I said I'm not very familiar with.

A wrong memory map would break grub, therefore these parts should be changed very carefully :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]