Re: [PATCH] Implement grub_sleep() and grub_ticksleep()

[Robert Millan]

Hi Marco,

On Sun, Oct 21, 2007 at 12:21:02PM +0200, Marco Gerards wrote:
> > diff -Nurp grub2/include/grub/misc.h grub2.time/include/grub/misc.h
> > --- grub2/include/grub/misc.h       2007-07-22 01:32:22.000000000 +0200
> > +++ grub2.time/include/grub/misc.h  2007-10-19 14:19:53.000000000 +0200
> > @@ -83,6 +83,7 @@ grub_uint64_t EXPORT_FUNC(grub_divmod64)
> >                                       grub_uint32_t d, grub_uint32_t *r);
> >  
> >  /* Inline functions.  */
> > +
> >  static inline unsigned int
> >  grub_abs (int x)
> 
> You accidently added a whitespace above.
> 
> Please remove this before you apply.

It looks accidental, but it was intended.  The whole code was changed from:

  /* Inline functions.  */
  grub_just_one_inline_function ()
  {
    stuff;
  }

to:

  /* Inline functions.  */

  grub_first_inline_function ()
  {
    stuff;
  }

  /* Comments on the second function */
  grub_second_inline_function ()
  {
    stuff;
  }

But if you still don't like that empty line, I have no objection on removing
it of course :-)

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)