Re: [PATCH] efika memory issues

[Hollis Blanchard]

On 7/30/07, Robert Millan <address@hidden> wrote:
> On Sun, Jul 29, 2007 at 09:30:11PM +0200, Robert Millan wrote:
> >
> > Hi Sven,
> >
> > I have a pair of questions about the memory issue..
> >
> > [...]
>
> Ok, after some discussion on IRC, and invaluable help by Sven in documenting
> smartfirmware behaviour, I came up with this patch.
>
> Please let me know what you think.  If there are no objections I'll check it
> in in a few days.
>
> 2007-07-30  Robert Millan  <address@hidden>
>
>         * include/grub/ieee1275/ieee1275.h (grub_ieee1275_flag): Add
>         GRUB_IEEE1275_FLAG_EFIKA_SECRET_AVAILABLE_REGION flag.
>         * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_find_options): Set
>         GRUB_IEEE1275_FLAG_EFIKA_SECRET_AVAILABLE_REGION flag when running
>         on an Efika (SmartFirmware).
>         * kern/powerpc/ieee1275/init.c (grub_claim_heap): Fail gracefuly when
>         addr > heaplimit.
>         Use grub_printf instead of grub_error for error reporting, since
>         grub_error doesn't work at this point of execution.
>         When GRUB_IEEE1275_FLAG_EFIKA_SECRET_AVAILABLE_REGION was set,
>         release hardcoded 0x4000:0xffc000 region.

Hmm, does this actually work? Since GRUB itself falls within that
regions, the grub_ieee1275_release() call will mark all the memory
that the GRUB kernel and modules occupy as free, which means they will
be clobbered by heap usage.

-Hollis