Re: serial module

[Marco Gerards]

Robert Millan <address@hidden> writes:

Hi,

> Any reason why the serial module is not enabled in i386-pc builds?  (see
> diff below)

You forgot a changelog entry :-/



> diff -ur grub2-1.95+20070621.old/conf/i386-pc.rmk 
> grub2-1.95+20070621/conf/i386-pc.rmk
> --- grub2-1.95+20070621.old/conf/i386-pc.rmk  2007-06-11 08:26:18.000000000 
> +0200
> +++ grub2-1.95+20070621/conf/i386-pc.rmk      2007-06-23 13:56:12.000000000 
> +0200
> @@ -91,7 +91,7 @@
>       commands/terminal.c commands/ls.c commands/test.c               \
>       commands/search.c commands/blocklist.c                          \
>       commands/i386/pc/halt.c commands/i386/pc/reboot.c               \
> -     commands/i386/cpuid.c                                           \
> +     commands/i386/cpuid.c term/i386/pc/serial.c                     \

Why do you add it to grub-emu?  This is wrong because you can't access
the hardware from grub-emu.  The same is true for cpuid, I think.  Are
you sure it works in grub-emu?  Please test if it still builds, when
adding stuff.

>       disk/loopback.c disk/raid.c disk/lvm.c                          \
>       fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c  \
>       fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c     \
> @@ -131,7 +131,7 @@
>  pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \
>       _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod      \
>       vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \
> -     videotest.mod play.mod bitmap.mod tga.mod cpuid.mod
> +     videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod

Good catch, I also wonder why this wasn't added.  Can you please apply
this change?

--
Marco