[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] strncpy misuse in ufs.c]
|
From: |
Marco Gerards |
|
Subject: |
Re: [patch] strncpy misuse in ufs.c] |
|
Date: |
Wed, 12 Apr 2006 10:29:17 +0200 |
|
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) |
Lubomir Kundrak <address@hidden> writes:
> EEh.... should actually read
>
> --- ufs.c.orig 2006-04-10 12:17:10.000000000 +0200
> +++ ufs.c 2006-04-10 12:17:32.000000000 +0200
> @@ -400,7 +400,7 @@
> unsigned int pos = 0;
> int dirino;
>
> - grub_strncpy (fpath, path, grub_strlen (path));
> + grub_strncpy (fpath, path, sizeof (fpath)+);
Why the floating plus? Isn't this wrong?
Can you please explain what the patch exactly fixes and why the
current code is wrong? Also, please submit a changelog entry.
--
Marco