Re: [patch] memory commands

[Hollis Blanchard]

On Jan 2, 2006, at 11:11 AM, Marco Gerards wrote:
> > +2005-12-12  Hollis Blanchard  <address@hidden>
> > +
> > +       * commands/memdebug.c: New file.
>
> > +       * kern/powerpc/misc.c: Likewise.
> > +       * include/grub/powerpc/misc.h: Likewise.
> > +       * include/grub/i386/misc.h: Likewise.
> > +       * include/grub/sparc64/misc.h: Likewise.
>
> Why don't you use trap.[ch]?  Calling it misc is a bit too generic I
> think, and I'm afraid everyone put everything in it.

That was my intention. Our build system makes it too painful to 
introduce (then move and rename and remove) new files, and this didn't 
seem important enough to merit its own header anyways.

> > +  grub_register_command ("memset", grub_cmd_memset, 
> > GRUB_COMMAND_FLAG_BOTH,
> > +                        "memset address (value [len] | trap)",
> > +                        "Write a 32-bit quantity to memory.", 0);
>
> This syntax is a bit unusual, I think (for a GNU program).  Mainly
> because it has quite some conditional parameters.  How about:
>
> memset --value=len
>
> or:
>
> memset --trap

"memset --address=foo --value=bar --len=baz" and "memset --address=foo 
--value=trap"? Far too much typing for a very simple operation.

> Can you please explain what this command does?  To be honest I don't
> really understand it immediately from the sourcecode. ;-)

It writes a value into a region of memory.

-Hollis