[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] 64 bit disk address support (= 8192EiB disks)

From: Yoshinori K. Okuji
Subject: Re: [patch] 64 bit disk address support (= 8192EiB disks)
Date: Sat, 22 Oct 2005 02:06:22 +0200
User-agent: KMail/1.7.2

On Saturday 22 October 2005 01:46 am, Timothy Baldwin wrote:
> > I think it is better to define grub_off_t as grub_uint64_t, and use
> > grub_off_t.
> Misleading as POSIX uses off_t as a byte offset. Also grub_off_t would be
> logical type name for file offsets, which should use a separate type to aid
> changing it.

I disagree. The development environment of GRUB was created to be 
intentionally similar to POSIX. For example, look at the usage of 
grub_size_t. It is rather convenient that one can guess how to program in 
GRUB based on an experience on POSIX.

> Also grub_off_t is used in kern/mm.c to count bytes of memory.

What is bad?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]