Re: [patch] PPC build fixes

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

[...]

> Because these commands need to be accessible from grub-emu (that is
> how you quit).

Oh, right.

>>>     * include/grub/powerpc/ieee1275/init.h: Remove inaccurate
>>>     comment.
>>
>> Can you change the comment to something sane?
>
> include/grub/i386/pc/init.h has no comment, and I don't know how to
> describe this anyways:
>       void cmain (uint32_t r3, uint32_t r4, uint32_t r5);
>       void grub_ofdisk_init (void);
>       void grub_console_init (void);

> "A tiny bit of miscellaneous stuff"? "Things related to booting"?

Ok, just remove it.  You are right again. :)

>>>     * util/powerpc/ieee1275/misc.c (grub_reboot): New function.
>>>     (grub_halt): Likewise.
>>
>> Isn't this just a completely new file?
>
> Er, yes, sorry. :)

Can you change these two lines to this:

        * util/powerpc/ieee1275/misc.c: New file

If you do this, you could commit the patch.  I can also do it if you
want.  After this we can concentrate on getting that boot-path patch
committed.  I will fix the initrd problem this weekend.

Thanks,
Marco