Re: [groff] Recent contrib/hdtbl changes may have broken it

[Bjarni Ingi Gislason]

On Sun, Nov 04, 2018 at 01:01:40AM -0400, G. Branden Robinson wrote:
> At 2018-10-27T03:02:59+0000, Bjarni Ingi Gislason wrote:
> > On Fri, Oct 26, 2018 at 04:28:02PM -0400, G. Branden Robinson wrote:
> > > Hi all,
> > > 
> > > 
> > [...]
> > >   GROFF    contrib/hdtbl/examples/color_nested_tables.ps
> > > ../contrib/hdtbl/examples/color_nested_tables.roff:40: The 1st width 
> > > value () is too small. It should be greater than 12000.
> > > ../contrib/hdtbl/examples/color_nested_tables.roff:52: The 1st width 
> > > value () is too small. It should be greater than 11999.
> > 
> >   I got those too.  I avoided the warnings by using "0.999n" instead of
> > "1n" in one of the arguments of "TBL".  The cause is thus most probably
> > a rounding error, so a better solution is to apply a correction where
> > the rounding error occurs.
> 
> These warnings appear to be caused by:
> 
> commit 305701e856baa0b23066279160eaeb38bd27b9e4
> Author: Ingo Schwarze <address@hidden>
> Date:   Thu Aug 9 22:50:47 2018 +0200
> 
>     contrib/hdtbl: do forgotten renamings .pv -> .t*pv
> 
>     This was forgotten in commit 6fb4a0ab on Feb 8, 2010.
>     Fixing it improves the formatting of all hdtbl examples.
>     Reported by Bjarni Ingi Gislason in http://savannah.gnu.org/bugs/?54470.
> 
>     While here, also fix a typo in short_reference.roff.
> 
> If I revert it, these warnings go away.
> 

  Removing the line

.t*pv 1.2 1.2 "" X

  in "common.roff" avoids the warnings.

  It also fixes the output of "color_nested_tables.ps" and "font_n.ps"

  If this line is needed in some file, it should be added there, for
example after including the "common.roff" file.

#

  col_rowspan_colors.roff: The "random-seed ..." line produces only a
one colored area in the middle instead of lines and columns of
different colors.

  That line must be outside the macro "color#"; otherwise the macro
always produces the same number, instead of random ones.

-- 
Bjarni I. Gislason