groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [groff] hyphenation issues


From: G. Branden Robinson
Subject: Re: [groff] hyphenation issues
Date: Sun, 6 May 2018 02:37:57 -0400
User-agent: NeoMutt/20170113 (1.7.2)

Getting back on topic...

At 2018-05-05T15:43:35+0200, Werner LEMBERG wrote:
[...]
> Please use `const int' – there is no single instance of `int const' in
> the groff code.
[...]
> >> I'd suggest adding
> >> 
> >>     HYPHEN_NONE = 0,
> >>     HYPHEN_DEFAULT = 1,
> >>     HYPHEN_MAX = 63 // Or whatever the local naming convention is.
> 
> Yes.
> 
> >> Then test for
> >> 
> >>     n > HYPHEN_MAX
> >>     n & HYPHEN_DEFAULT && n & ~HYPHEN_DEFAULT
> >> 
> >> in addition to the existing
[...]
> I prefer that.

Fresh patch, test case, and test case output attached.

My debugging instincts tell me to always report the value of an argument
being rejected.  For one thing, the user could have passed .hy a
register value (possibly with arithmetic manipulation), and if we screw
up the validity checks it's easier to see which cases are incorrect.

Comments?

-- 
Regards,
Branden

Attachment: hyph.diff
Description: Text Data

Attachment: hy.trf
Description: Text document

Attachment: hy.trf.out
Description: Text document

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]