groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [groff] Commit [09040dbf] is wrong


From: Steffen Nurpmeso
Subject: Re: [groff] Commit [09040dbf] is wrong
Date: Thu, 16 Nov 2017 00:39:33 +0100
User-agent: s-nail v14.9.5-29-gab03c38f

i wrote:
  ...
 |I am here for something else, the commit mentioned changed
  ...
 |I come up with (uncompiled and untested):
 ...
 |
 |  void
 |  char_buffer::write_upto_newline(char_block **t, int *i, int is_html){
 |    enum {a_NONE, a_NL, a_LEADER} ev;
 |    char *b;
 |    int j, u;
 |
 |    if(*t == NULL)
 |      goto jleave;
 |
 |    j = *i;
 |    u = (*t)->used;
 |    b = (*t)->buffer;
 |    ev = a_NONE;
 |
 |    for(; j < u; ++j){
 |      if(b[j] == '\n'){

Blush.  This should have been

      ev = (++j < u && b[j] == HTML_INLINE_LEADER_CHAR) ? a_LEADER : a_NL;

instead.  Now fixed.  (Still uncompiled and untested, of course.)

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]