[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Groff] Re: groff 1.18.1 memory allocation bugs
From: |
Bernd Warken |
Subject: |
[Groff] Re: groff 1.18.1 memory allocation bugs |
Date: |
Sun, 30 Mar 2003 21:32:18 +0200 |
User-agent: |
Mutt/1.2.5i |
On Sun, Mar 30, 2003 at 03:00:52AM +0200, Ivan Popov wrote:
> Hello,
>
> I have identified a couple of places in groff where it is doing
> wrong things with memory allocation.
>
> There are probably more places there, but I can't spend more time on
> reading the source, neither am I good at C++.
>
> I attach the patch that enables me compile and use groff with
> gcc 3.2.2 and corresponding libstdc++. Without the patch groff and
> pre-grohtml segfault. With the patch they do not segfault at once at
> least.
>
> The patch is not "right", but it can show the problem and a
> possible fix. In new.cc one should redefine either both
> new and delete, or none of them, imho. I do not know how to do it right.
> Likewise usage of malloc() and then delete on the same object is
> unacceptable.
To get rid of `malloc' is a good idea to remove bad C style and to
fully make groff a C++ project. There are more similar things to be
done.
Bernd Warken
- [Groff] Re: groff 1.18.1 memory allocation bugs,
Bernd Warken <=