[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[groff] 08/32: tmac/fallbacks.tmac: Mitigate Savannah #63332.
From: |
G. Branden Robinson |
Subject: |
[groff] 08/32: tmac/fallbacks.tmac: Mitigate Savannah #63332. |
Date: |
Wed, 30 Nov 2022 07:25:52 -0500 (EST) |
gbranden pushed a commit to branch master
in repository groff.
commit 563fd71746331f5feafe87a468d0326e8bfc8786
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Nov 27 03:30:38 2022 -0600
tmac/fallbacks.tmac: Mitigate Savannah #63332.
* tmac/fallbacks.tmac: Comment out four of the fallback character
definitions for (preconv'd) Unicode character input added to address
Savannah #58930 (corresponding to \[dg], \[dd], \[%0], and \[rn]; they
are failing for not yet understood reasons involving "macros" attached
to groff character info structs, and the semantics of what it means
for a character to "exist" per the 'c' conditional operator. Fixes
regression when using "tty-char.tmac" (which nroff loads by default).
Problem introduced by me in commit 132182bd71, 23 October. The hope
is to resolve this issue post-groff 1.23.0. Thanks to Dave Kemper for
the report and discussion in Savannah #63332.
---
ChangeLog | 14 ++++++++++++++
tmac/fallbacks.tmac | 9 +++++----
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index a93ca20d5..badd6d8dd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2022-11-27 G. Branden Robinson <g.branden.robinson@gmail.com>
+
+ * tmac/fallbacks.tmac: Comment out four of the fallback
+ character definitions for (preconv'd) Unicode character input
+ added to address Savannah #58930 (corresponding to \[dg], \[dd],
+ \[%0], and \[rn]; they are failing for not yet understood
+ reasons involving "macros" attached to groff character info
+ structs, and the semantics of what it means for a character to
+ "exist" per the 'c' conditional operator. Fixes regression when
+ using "tty-char.tmac" (which nroff loads by default). Problem
+ introduced by me in commit 132182bd71, 23 October. The hope is
+ to resolve this issue post-groff 1.23.0. Thanks to Dave Kemper
+ for the report and discussion in Savannah #63332.
+
2022-11-25 G. Branden Robinson <g.branden.robinson@gmail.com>
* tmac/an-ext.tmac (SY, YS, mV): Remove `mA`, `mI`, and `mT`
diff --git a/tmac/fallbacks.tmac b/tmac/fallbacks.tmac
index 633dbc711..9ba22c0f5 100644
--- a/tmac/fallbacks.tmac
+++ b/tmac/fallbacks.tmac
@@ -167,20 +167,21 @@
.fchar \[u2019] \[cq]\" right single quotation mark
.fchar \[u201C] \[lq]\" left double quotation mark
.fchar \[u201D] \[rq]\" right double quotation mark
-.fchar \[u2020] \[dg]\" dagger
-.fchar \[u2021] \[dd]\" double dagger
+.\" XXX: The next two are troublesome; see Savannah #63332.
+.\"fchar \[u2020] \[dg]\" dagger
+.\"fchar \[u2021] \[dd]\" double dagger
.fchar \[u2022] \[bu]\" bullet
.fchar \[u2024] .\" one dot leader
.fchar \[u2025] .\|.\" two dot leader
.fchar \[u2026] .\|.\|.\" horizontal ellipsis
.fchar \[u2027] \[pc]\" hyphenation point
-.fchar \[u2030] \[%0]\" per mille sign
+.\"fchar \[u2030] \[%0]\" per mille sign \" Savannah #63332 again
.fchar \[u2032] \[fm]\" prime
.fchar \[u2033] \[sd]\" double prime
.fchar \[u2039] \[fo]\" left single chevron
.fchar \[u203A] \[fc]\" right single chevron
.if t .fchar \[u203D] \o'?!'\" interrobang
-.fchar \[u203E] \[rn]\" overline
+.\"fchar \[u203E] \[rn]\" overline \" Savannah #63332 again
.fchar \[u2044] \[f/]\" fraction slash
.fchar \[u2052] %\" commercial minus sign
.fchar \[u2053] \[ti]\" swung dash
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [groff] 08/32: tmac/fallbacks.tmac: Mitigate Savannah #63332.,
G. Branden Robinson <=