[groff] 01/01: [doc] fix non-portable syntax in the groff-man-pages.* targets

[Ingo Schwarze]

schwarze pushed a commit to branch master
in repository groff.

commit 97b80013f54201d37976d6f4916cbb38139d851a
Author: Ingo Schwarze <schwarze@openbsd.org>
AuthorDate: Tue Mar 22 15:28:24 2022 +0100

    [doc] fix non-portable syntax in the groff-man-pages.* targets
    
    The DOC_GROFF facility uses the $< variable which POSIX only defines
    for use in suffix rules, but the doc/groff-man-pages.pdf and
    doc/groff-man-pages.utf8.txt rules are not suffix rules and use it
    anyway.  Besides, the whole point of DOC_GROFF is to manipulate
    standard input, but then providing file name arguments afterwards
    causes groff to discard the modified input.
    
    Fix this by using DOC_GROFF_ONLY instead of DOC_GROFF for these
    two rules; it does all that is needed.
    
    OK and tested by gbranden@
---
 ChangeLog  | 7 +++++++
 doc/doc.am | 4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 43ff2312..820e33cc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2022-03-22  Ingo Schwarze <schwarze@openbsd.org>
+
+       * doc/doc.am: fix non-portable syntax in the groff-man-pages.*
+       targets by using DOC_GROFF_ONLY rather than DOC_GROFF in order
+       to not use $< outside a suffix rule; DOC_GROFF functionality is
+       not needed here in the first place.
+
 2022-03-21  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * tmac/an.tmac:
diff --git a/doc/doc.am b/doc/doc.am
index 44f8c73e..0f4bfb9d 100644
--- a/doc/doc.am
+++ b/doc/doc.am
@@ -229,13 +229,13 @@ man-clean:
        $(RM) $(GROFF_MAN_PAGES_ALL)
 
 doc/groff-man-pages.pdf: $(GROFF_MAN_PAGES_ALL)
-       $(GROFF_V)$(DOC_GROFF) -Tpdf -P-e -mandoc -rC1 \
+       $(GROFF_V)$(DOC_GROFF_ONLY) -Tpdf -P-e -mandoc -rC1 \
          -rCHECKSTYLE=3 $(GROFF_MAN_PAGES1) \
          $(tmac_srcdir)/sv.tmac $(GROFF_MAN_PAGES2) \
          $(tmac_srcdir)/en.tmac $(GROFF_MAN_PAGES3) > $@
 
 doc/groff-man-pages.utf8.txt: $(GROFF_MAN_PAGES_ALL)
-       $(GROFF_V)$(DOC_GROFF) -Tutf8 -mandoc \
+       $(GROFF_V)$(DOC_GROFF_ONLY) -Tutf8 -mandoc \
          -rCHECKSTYLE=3 $(GROFF_MAN_PAGES1) \
          $(tmac_srcdir)/sv.tmac $(GROFF_MAN_PAGES2) \
          $(tmac_srcdir)/en.tmac $(GROFF_MAN_PAGES3) > $@