[groff] 11/35: [grotty]: Remove 'sgr' device control command.

[G. Branden Robinson]

gbranden pushed a commit to branch master
in repository groff.

commit dec7367f785e1482dc79aaaaa83436248cea790c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Wed Feb 16 14:43:19 2022 +1100

    [grotty]: Remove 'sgr' device control command.
    
    * src/devices/grotty/tty.cpp (tty_printer::special): Do it.
    * src/devices/grotty/grotty.1.man (Device control commands):
      (De-)document it.
    * NEWS: Add item.
    
    Fixes <https://savannah.gnu.org/bugs/?61561>.
---
 ChangeLog                       | 11 +++++++++++
 NEWS                            |  6 ++++++
 src/devices/grotty/grotty.1.man | 20 --------------------
 src/devices/grotty/tty.cpp      | 12 +-----------
 4 files changed, 18 insertions(+), 31 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 977ddde6..97b9cd8a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2022-02-16  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [grotty]: Remove 'sgr' device control command.
+
+       * src/devices/grotty/tty.cpp (tty_printer::special): Do it.
+       * src/devices/grotty/grotty.1.man (Device control commands):
+       {De-}document it.
+       * NEWS: Add item.
+
+       Fixes <https://savannah.gnu.org/bugs/?61561>.
+
 2022-02-15  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * tmac/pdfpic.tmac: Add support for Cygwin/MinGW temporary
diff --git a/NEWS b/NEWS
index c09bd17b..7885fb77 100644
--- a/NEWS
+++ b/NEWS
@@ -354,6 +354,12 @@ o On the Latin-1 output device ("groff -T latin1") the 
special character
   sequences like `this' in the input (character remapping with 'char'
   requests and similar notwithstanding).
 
+o The "sgr" device control command, which dynamically configured support
+  for ISO 6429/EMA-48 SGR escape sequences (and restored traditional
+  overstriking behavior if disabled), has been removed.  It took effect
+  only at page boundaries.  grotty's "-c" command-line option and the
+  GROFF_NO_SGR environment variable remain supported.
+
 Miscellaneous
 -------------
 
diff --git a/src/devices/grotty/grotty.1.man b/src/devices/grotty/grotty.1.man
index f1695144..ae70b2dc 100644
--- a/src/devices/grotty/grotty.1.man
+++ b/src/devices/grotty/grotty.1.man
@@ -309,26 +309,6 @@ or
 they must be represented in an alternate form.
 .
 .
-.TP
-.BR "\[rs]X\[aq]tty: sgr " [\c
-.IR n ]\c
-.B \[aq]
-.
-If
-.I n
-is non-zero or missing,
-enable SGR sequences
-(this is the default);
-otherwise,
-use the legacy output format.
-.
-This device control command,
-like the
-.B \-c
-option,
-also prevents the emission of terminal OSC 8 hyperlink escape sequences.
-.
-.
 .\" ====================================================================
 .SS "Device description files"
 .\" ====================================================================
diff --git a/src/devices/grotty/tty.cpp b/src/devices/grotty/tty.cpp
index fcdc1faa..5d94310a 100644
--- a/src/devices/grotty/tty.cpp
+++ b/src/devices/grotty/tty.cpp
@@ -445,17 +445,7 @@ void tty_printer::special(char *arg, const environment 
*env, char type)
     error("empty X command ignored");
     return;
   }
-  if (strncmp(command, "sgr", p - command) == 0) {
-    for (; *p == ' ' || *p == '\n'; p++)
-      ;
-    int n;
-    if (*p != '\0' && sscanf(p, "%d", &n) == 1 && n == 0)
-      use_overstriking_drawing_scheme = true;
-    else
-      use_overstriking_drawing_scheme = false;
-    update_options();
-  }
-  else if (strncmp(command, "link", p - command) == 0)
+  if (strncmp(command, "link", p - command) == 0)
     special_link(p, env);
 }