groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 08/14: [grog]: Improve unrecognized option diagnostic.


From: G. Branden Robinson
Subject: [groff] 08/14: [grog]: Improve unrecognized option diagnostic.
Date: Mon, 28 Jun 2021 00:44:51 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 63582757863e6b9ef0a9c4c7dcb1e3c2583689a6
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Jun 27 15:30:17 2021 +1000

    [grog]: Improve unrecognized option diagnostic.
    
    * src/utils/grog/grog.pl (handle_args): Complain less noisily and more
      comprehensibly when given unrecognized groff options.
    
    Before:
        $ grog -A
        /usr/lib/groff/grog/subs.pl 302: unknown argument -A
        groff -A -T ps -
    
    After:
        $ ./build/grog -A
        grog: warning: unrecognized groff option: -A
        groff -A -T ps -
---
 ChangeLog              | 5 +++++
 src/utils/grog/grog.pl | 3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 67245d0..f270630 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2021-06-27  G. Branden Robinson <g.branden.robinson@gmail.com>
 
+       * src/utils/grog/grog.pl (handle_args): Complain less noisily
+       and more comprehensibly when given unrecognized groff options.
+
+2021-06-27  G. Branden Robinson <g.branden.robinson@gmail.com>
+
        [grog]: Handle "--" argument as documented.
 
        * src/utils/grog/grog.pl (handle_args): Rename scalar
diff --git a/src/utils/grog/grog.pl b/src/utils/grog/grog.pl
index 89a5661..a89834e 100644
--- a/src/utils/grog/grog.pl
+++ b/src/utils/grog/grog.pl
@@ -283,8 +283,7 @@ sub handle_args {
        # arg finished
        next;
       } else {         # not a groff opt
-       print STDERR __FILE__ . ' '  . __LINE__ . ': ' .
-         'unknown argument ' . $arg;
+       &warn("unrecognized groff option: $arg");
        push(@Command, $arg);
        next;
       }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]