grep-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Grep-devel] [PATCH] tests: remove stale surrogate-pair test


From: Jim Meyering
Subject: [Grep-devel] [PATCH] tests: remove stale surrogate-pair test
Date: Sun, 16 Dec 2018 11:08:54 -0800

FYI:

>From bdb98cec2e7bf255e1d00eaf8be16299f7bf571e Mon Sep 17 00:00:00 2001
Date: Sun, 16 Dec 2018 11:05:43 -0800
Subject: [PATCH] tests: remove stale surrogate-pair test

The cygwin-specific code for surrogate pairs was first disconnected
via v2.21-62-g936c904 and later removed as part of a then-unused
function via v2.24-12-g704de87. So now I'm removing the test, too.
If someone thinks it important and would like to revive it, please do.
* tests/surrogate-pair: Remove file.
* tests/Makefile.am (TESTS): Remove it.
---
 tests/Makefile.am    |  1 -
 tests/surrogate-pair | 43 -------------------------------------------
 2 files changed, 44 deletions(-)
 delete mode 100755 tests/surrogate-pair

diff --git a/tests/Makefile.am b/tests/Makefile.am
index a7e8f27..872024f 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -153,7 +153,6 @@ TESTS =                                             \
   spencer1-locale                              \
   stack-overflow                               \
   status                                       \
-  surrogate-pair                               \
   symlink                                      \
   triple-backref                               \
   turkish-I                                    \
diff --git a/tests/surrogate-pair b/tests/surrogate-pair
deleted file mode 100755
index ffa564a..0000000
--- a/tests/surrogate-pair
+++ /dev/null
@@ -1,43 +0,0 @@
-#!/bin/sh
-# Trigger a segfault-inducing bug with -i in grep-2.14 on Cygwin.
-
-# Copyright (C) 2013-2018 Free Software Foundation, Inc.
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-. "${srcdir=.}/init.sh"; path_prepend_ ../src
-
-require_en_utf8_locale_
-require_compiled_in_MB_support
-
-fail=0
-
-printf '\360\220\220\205\n' > in || framework_failure_
-
-LC_ALL=en_US.UTF-8
-export LC_ALL
-
-# On Cygwin, before grep-2.15, this would segfault.
-# Require not just non-zero exit status, but exactly 1.
-returns_ 1 grep -i anything-else in > out 2>&1 || fail=1
-# Expect no output.
-compare /dev/null out || fail=1
-
-# Also test whether a surrogate-pair in the search string works.
-for opt in '' -i -E -F -iE -iF; do
-  grep --file=in $opt in > out 2>&1 || fail=1
-  compare out in || fail=1
-done
-
-Exit $fail
--
2.20.1.2.gb21ebb671b



reply via email to

[Prev in Thread] Current Thread [Next in Thread]