Re: [gpsd-users] gps_read () message buffer

[Gary E. Miller]

Yo Charles!

On Tue, 26 Feb 2019 16:01:08 -0700
Charles Curley <address@hidden> wrote:

> Having done a bit of sleuthing in the gpsd source, I think I have some
> additional documentation for gps_read. See the attached diff.
> 
> Please check it for accuracy!

The size of the buffer is not really important.  You just keep reading
until there is no more to read.

So there is not need for "at least 4096 bytes".  Although that is
a suitable size.

> One request....
> 
> * I found the value for the size of the buffer by reading the source
> for cgps, and tracking down where GPS_JSON_RESPONSE_MAX was defined,
> in gps_json.h. That value is likely to grow in the future. Would you
>   please provide a suitable #define in gps.h?

What is wrong with GPS_JSON_RESPONSE_MAX?  You want to be several times
larger so you emtpy the buffer in one call.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgprCO7iknOy0.pgp
Description: OpenPGP digital signature