gpsd-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-users] Status of my patches.


From: Gary E. Miller
Subject: Re: [gpsd-users] Status of my patches.
Date: Tue, 4 Sep 2018 20:11:29 -0700

Yo Sven!

On Fri, 31 Aug 2018 17:01:00 +0200
Sven Geggus <address@hidden> wrote:

> I just wanted to ask what happend to the patches I posted in mid
> August.

I just applied three patches in two commits.  Please check them.

The first commit added the missing line endings (\r\n) to the two
bad JSON messages.  Plus the AIS capture you sent as a regression test.

There were seven bad messages in the capture file, i just removed them.

The second commit changed some of the precision of some AIS LAT/LON.  No
regession test changes.

That last part is bad.  That means gpsd has no regression tests for the
LAT/LON message types that were changed.  Can you grab some AIS messages
that show the change?  That will help prevent bit rot.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

Attachment: pgpMY6zHcXci3.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]