gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Introduce Qualcomm PDS service support


From: Greg Troxel
Subject: Re: [PATCH] Introduce Qualcomm PDS service support
Date: Mon, 25 May 2020 21:12:55 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix)

Anibal Limon <address@hidden> writes:

> On Mon, 25 May 2020 at 19:42, Greg Troxel <address@hidden> wrote:
>
>> Aníbal Limón <address@hidden> writes:
>>
>> > The Qualcomm PDS service provides location data on a wide range of
>> > Qualcomm platforms. It used QMI encoded messages sent over a shared
>> > memory link, implemented in Linux as AF_QIPCRTR.
>>
>> It looks like this is enabled by default and includes linux-specific
>> headers with an #ifdef linux guard.
>
> Right, At this moment only on Linux the support exists, this Qualcomm PDS
> service is used by the integrated GPS on Dragonboard410c (QCOM APQ8016).
> I will add a conditional SConstruct/boolopts make it dependent of Linux
> platform, any other required change to make only build on Linux?

That sounds like it might be enough.   I just wanted to ask that you
ensure that with the change the behavior is sensible on non-Linux
platforms.   If that means that the "build pds" variable defaults to on
only for Linux, and off elsewhere, that sounds reasonable.   Also I'm
not sure if older or different Linux would have what you need or not, so
you may need to conditionalize on more.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]