Re: master fails to build/check

[Ladislav Michl]

On Sat, Feb 01, 2020 at 03:05:11PM -0800, Gary E. Miller wrote:
> Yo Ladislav!
> 
> On Sat, 1 Feb 2020 17:28:44 +0100
> Ladislav Michl <address@hidden> wrote:
> 
> > Hello Garry,
> 
> One R please.

Apologies.

> > > I know pkg-config sometimes works, for some people.
> > > That says nothing about pkg-config working for all people all the
> > > time.  
> > 
> > Seems we are in "Pot, kettle, black" swamp again...
> 
> I don't see how.  You say pkg-config is all you need.  I say it is
> not enough for everyone.  If you want to fork gpsd that only works for
> your use case, have at it.

I'm expecting those "everyones" to speak and tell what is broken for them.
No need to fork anything on my side, I'm fine without gpsd's sysroot.

> > > I'm saying, as fact, that pkg-config does not work for all people
> > > all the time.  Nice to have, do not count on it.  Works for you is
> > > nice for you. Works for everyone is a good patch.  
> > 
> > I'm obviously unable to fix all people problems for eternity. I'm just
> > stating I do not need to use gpsd's sysroot as long as pkg-config does
> > the job for me.
> 
> As you have stated many times, and as I have stated: if you don't want it
> don't use it.

That's what I'm doing. And obviously cannot fix problems I'm not aware of.

> There is a finite number of times I'll repeat myself when no new
> data is added to the conversation.

So add them and show how it is not enough for everyone. For me it is
easier to fix pkg-config than use gpsd's approach to sysroot.
[...]
> I'm all for the rationale.  The correlation of "target" and wanting
> systemd stuff is small.  Unless we find a perfectly correlated set
> of variables his may need a new variable.  

All I asked is: what is wrong with this patch and how it should be
modified to match your expectations?
--- a/SConstruct
+++ b/SConstruct
@@ -2752,7 +2752,7 @@ udev_install = Utility('udev-install', 'install', [
 
 if env['systemd']:
     env.Requires(udev_install, systemd_install)
-    if not env["sysroot"]:
+    if not env['target']:
         systemctl_daemon_reload = Utility('systemctl-daemon-reload', '',
                                           ['systemctl daemon-reload || true'])
         env.AlwaysBuild(systemctl_daemon_reload)

> > > Uh?  I prefer not to waste time on fantasy issues.  If it is not
> > > real to you, why are you bringing it up?  
> > 
> > I call problems I'm unable to solve or to solve them using enormous
> > efford real problems.
> 
> Clearly we are not speaking the same english.

Pity you pick only the less relevant part of anwer ;-)

> So, I'm gonna stop here.  You keep talking around the problem, but
> not about specifics of your problem.  No build log, no config log, no
> description of your build environment.  Etc.  So I'll wait for more
> patches to evaluate, and skip the bike shedding.

If that means you'll focus on "not breaking normal builds" part...
That might work then.