Re: ✘leapsecond.py

[Bernd Zeimetz]

On 11/2/19 1:11 AM, Gary E. Miller wrote:

>> But imho the whole thing is a mess as it assumes that there is only
>> one leapsecond per year and I think that leapseconds.cache file is
>> only used to count the number of lines.
> 
> Yup.  Is this worth fixing?

I'd drop that line counting code and just provide a way to get the
leapseconds and update the header file automatically.

> 
>> I *think* the proper fix would be to parse the number of leapseconds
>> from the bulletin and just use it. No idea why we need to keep a
>> history of that stuff and count lines while assuming a line means one
>> seconds....
> 
> If the goal is a reproduceable build, any objections to just
> hard coding:
> 
> #define BUILD_CENTURY   2000
> #define BUILD_LEAPSECONDS       18
> 
> And update the file manually every release?
> 
> Will people really be building old versions of gpsd after leap second
> changes?  Or just wait until the next releave (or five).

we could do that in debian to include leapsecond changes, but as the
build daemons do not have internet access it some manual update is
necessary anyway. And it doesn't matter which file is being updated.

no idea if anybody out there needs that automatic update feature.

but given the fact that it is probably broken since ever, I guess nobody
cared enough.


-- 
 Bernd Zeimetz                            Debian GNU/Linux Developer
 http://bzed.de                                http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485  DD95 EB36 171A 6FF9 435F