Re: [gpsd-dev] patches from pkgsrc: SConstruct

[Gary E. Miller]

Yo Greg!

On Thu, 20 Jun 2019 11:08:46 -0400
Greg Troxel <address@hidden> wrote:

> I've added 3 variables to SConstruct's pass-through list.
> 
> Not required for this change, but I tested by:
> 
>   - building a distfile
>   - building a pkgsrc package from that distfile and installing it
>   - running gpsd, and verifying ntp shm and xgps (netbsd-8, amd64)

Those changes look good.

OTOH, some of the comment changes are wrong. 

For example: _BSD_SOURCE is certainly not Linux only.  It is glibx.

I just re-verified.  This is not true:

+        # required because _XOPEN_SOURCE above restricts visibility of
+        # all things not defined by XOPEN

Easy to confirm on netbad:

    fgrep XOPEN_SOURCE /usr/include -r

Please use TODO instead of \todo.  That is a keyword that triggers
some tools we use.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpPZPbC2PAZa.pgp
Description: OpenPGP digital signature