Re: [gpsd-dev] ✘CentOS fixed?

[Fred Wright]

On Fri, 14 Jun 2019, Gary E. Miller wrote:
> On Fri, 14 Jun 2019 16:38:43 -0700 (PDT)
> Fred Wright <address@hidden> wrote:
>
> > On Fri, 14 Jun 2019, Gary E. Miller wrote:
> > > Maybe I just fixed all the CentOS warnings.  Please test.
> > >
> > > The CentOS I installed was 32-bit.  scons needs epel, which does not
> > > suupport 32-bit.  So I'll try again with a 64-bit CentOS.
> >
> > For what I have here, it's down to warnings on Ubuntu, and both
> > warnings and errors on OpenBSD.

And still the same @6ed457c61.

> And these from your Macs:

Those aren't "Macs" - they're OpenBSD VMs running on the Mac.

> MacOpen: gpsmon.c:441: warning: implicit declaration of function 'strlcpy'
> MacOpen: gpsmon.c:443: warning: implicit declaration of function 'strlcat'
>
> Those are in string.h, and should be unlocked by _DARWIN_C_SOURCE,
> which then sets __USE_MISC.

I don't think _DARWIN_C_SOURCE helps on OpenBSD. :-)

> Can you please look in your header files for the magic key?
>
> Prolly found in <sys/cdefs.h> and <string.h>

Yes, when I looked at that stuff before, it looked like defining 
_BSD_SOURCE is appropriate for FreeBSD and OpenBSD, while NetBSD needs 
_NETBSD_SOURCE.

I don't see _BSD_SOURCE in gpsd_config.h on OpenBSD.  I expect that fixing 
that will take care of the the strlcpy/strlcat issue, and maybe some 
others.  It's not really clear to be why 64-bit OpenBSD gets more warnings 
than 32-bit OpenBSD (same version), though.

The actual error (causing the build to fail) relates to SIGWINCH.  We can 
see if it persists after fixing _BSD_SOURCE.

I'm not convinced that defining __USE_MISC directly is necessary once the 
other definitions are correct.

I can send another report, though I think it's pretty much the same as the 
last one.

Fred Wright