|
From: | Fred Wright |
Subject: | Re: [gpsd-dev] Fw: [gpsd-commit-watch] [SCM] GPSD branch, master, updated. dev-3.19a-744-g4b1c33b |
Date: | Tue, 28 May 2019 18:11:10 -0700 (PDT) |
User-agent: | Alpine 2.21 (LRH 202 2017-01-01) |
On Tue, 28 May 2019, Gary E. Miller wrote:
"This fix, first added in commit 9af0ab644, was inappropriately removed by commit 6e2842d3e. It now has a more detailed comment explaining why it's not redundant with the other filtering." How about fixing this case for ALL clients and not just xgps?
It was already fixed for all clients (see the original commit). It only got unfixed for xgps, so it only needed to be refixed for xgps.
The only place you could be with a SBAS bird at 0/0 would be somewhere south east of Easter Island .
The filter isn't SBAS-specific, since that would make it more complicated. But even a nav satellite at 0/0 wouldn't be actually used by most receivers, due to the masking angle, so the potential false positive is fairly benign. Requiring *both* el and az to be zero is to minimize this.
Fred Wright
[Prev in Thread] | Current Thread | [Next in Thread] |