Re: Not sure if it could be considered as a bug, concern the tests suite, let you see

[gmail]

Hello,

I check the dsatest with a pure bourne shell (SVR4/SVID3 level), the 
heirloom Bourne Shell (http://heirloom.sourceforge.net/sh.html) , the 
test works correctly :

    address@hidden # cd gnutls-2.12.0_build/tests/dsa

    address@hidden # rm /bin/sh

    address@hidden # ln -s /5bin/sh /bin/sh

    address@hidden # make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Checking server DSA-1024 with client DSA-1024 and TLS 1.0
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.0
    Checking server DSA-1024 with client DSA-3072 and TLS 1.0
    Checking DSA-1024 with TLS 1.2
    Checking server DSA-1024 with client DSA-1024 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-3072 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking DSA-2048 with TLS 1.0
    Checking DSA-2048 with TLS 1.2
    Checking DSA-3072 with TLS 1.0
    Checking DSA-3072 with TLS 1.2
    PASS: testdsa
    =============
    1 test passed
    =============
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'

    address@hidden # /5bin/sh --version

    address@hidden \W]\$ <[CTRL] [D]>

    address@hidden # /5bin/sh --v

    address@hidden \W]\$ <[CTRL] [D]>

    address@hidden # /5bin/sh -v

    address@hidden \W]\$ <[CTRL] [D]>


And to be sure ...


    address@hidden dsa] # sh

    address@hidden \W]\$ make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Checking server DSA-1024 with client DSA-1024 and TLS 1.0
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.0
    Checking server DSA-1024 with client DSA-3072 and TLS 1.0
    Checking DSA-1024 with TLS 1.2
    Checking server DSA-1024 with client DSA-1024 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-3072 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking DSA-2048 with TLS 1.0
    Checking DSA-2048 with TLS 1.2
    Checking DSA-3072 with TLS 1.0
    Checking DSA-3072 with TLS 1.2
    PASS: testdsa
    =============
    1 test passed
    =============
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'

    address@hidden \W]\$

    address@hidden \W]\$ sshd -p 5559

    address@hidden \W]\$ make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Failed to launch a gnutls-serv server !
    Failure: Failed to launch a gnutls-serv server, aborting dsatest...
    FAIL: testdsa
    ===================================
    1 of 1 test failed
    Please report to address@hidden
    ===================================
    make[1]: *** [check-TESTS] Error 1
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make: *** [check-am] Error 2

    address@hidden \W]\$ netstat -pan | grep 5559

    tcp        0      0 0.0.0.0:5559            0.0.0.0:*               
LISTEN      11884/sshd

    address@hidden \W]\$ kill 11884

    address@hidden \W]\$ make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Checking server DSA-1024 with client DSA-1024 and TLS 1.0
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.0
    Checking server DSA-1024 with client DSA-3072 and TLS 1.0
    Checking DSA-1024 with TLS 1.2
    Checking server DSA-1024 with client DSA-1024 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-3072 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking DSA-2048 with TLS 1.0
    Checking DSA-2048 with TLS 1.2
    Checking DSA-3072 with TLS 1.0
    Checking DSA-3072 with TLS 1.2
    PASS: testdsa
    =============
    1 test passed
    =============
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'

    address@hidden \W]\$ ../../src/gnutls-serv -d 9 -p 5559 --priority 
"NORMAL:-VERS-TLS-ALL:+VERS-TLS1.0" --x509certfile 
../../../gnutls-2.12.0/tests/dsa/cert.dsa.1024.pem --x509keyfile 
../../../gnutls-2.12.0/tests/dsa/dsa.1024.pem >/dev/null 2>&1 &

    12721

    address@hidden \W]\$ make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Failed to launch a gnutls-serv server !
    Failure: Failed to launch a gnutls-serv server, aborting dsatest...
    FAIL: testdsa
    ===================================
    1 of 1 test failed
    Please report to address@hidden
    ===================================
    make[1]: *** [check-TESTS] Error 1
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make: *** [check-am] Error 2

    address@hidden \W]\$ kill 12721

    address@hidden \W]\$ make check

    make  testdsa
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make[1]: Nothing to be done for 
`../../../gnutls-2.12.0/tests/dsa/testdsa'.
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    make  check-TESTS
    make[1]: Entering directory `/usr/src/gnutls-2.12.0_build/tests/dsa'
    Checking various DSA key sizes
    Checking DSA-1024 with TLS 1.0
    Checking server DSA-1024 with client DSA-1024 and TLS 1.0
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.0
    Checking server DSA-1024 with client DSA-3072 and TLS 1.0
    Checking DSA-1024 with TLS 1.2
    Checking server DSA-1024 with client DSA-1024 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-2048 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking server DSA-1024 with client DSA-3072 and TLS 1.2
    Processed 1 client certificates...
    Processed 1 client X.509 certificates...
    Checking DSA-2048 with TLS 1.0
    Checking DSA-2048 with TLS 1.2
    Checking DSA-3072 with TLS 1.0
    Checking DSA-3072 with TLS 1.2
    PASS: testdsa
    =============
    1 test passed
    =============
    make[1]: Leaving directory `/usr/src/gnutls-2.12.0_build/tests/dsa'

    address@hidden \W]\$


   Therefore, the testdsa script seems to be fully bourne shell 
original compliant.

    (Finding sources tarball of a "pure" bourne shell was the most 
difficult part...)



    Actually, the gnutls-2.12.0_build/lib/libtool script does not work 
with the bourne shell due to syntax forms like the one used in this 
function :

              func_arith ()
              {
                func_arith_result=$(( $* ))
              }

    Then i can't launch directly all the tests suite. I can however 
test each script one by one. Do you think it's better to adapt the tools 
scripts first or to check the test scripts first ?

    Regards, Cédric.


Le 29/03/2011 10:21, Nikos Mavrogiannopoulos a écrit :
> On 03/29/2011 01:02 AM, gmail wrote:
> > Hello,
> > I then launch a daemon on port 5559 with the goal to prevent tls server
> > launch and check how the test deal with potential launch failure :
> [...]
> > The test correctly fail, but without mention tls_server launch has failed.
> > To show how this could be confusing, checking again with a forced TLS
> > server 1.0 :
> [...]
> > The test correclty fail,  the "./../../gnutls-2.12.0/tests/dsa/testdsa:
> > line 68: kill: (8793) - No such process" gives some tips about the real
> > issue but the "incompatible DSA key" messages could lead to misundertood
> > it.
> > Perhaps this does not worth any efforts, but what did you think about
> > this (normaly bourne compatible) patch :
> Actually it is pretty interesting (maybe not for this release but
> in general), because I would like to have more test cases as bourne
> shell scripts, and having such a library would help a lot. Thanks for
> the ideas and patches. I'll include it in master.
>
> regards,
> Nikos