Re: [gnutls-dev] [PATCH] Load DH Params from File

[Simon Josefsson]

Mr Allwyn Fernandes <address@hidden> writes:

> Hi,
>
> (Apologies if anyone gets this multiple times: I've tried sending it several 
> times, and keep getting bounce messages... I don't see it in any of the 
> archives so I _suspect_ it hasn't gotten through to anyone, but I'm not 
> sure.)

Hi!  Sorry about that, I think the address@hidden list is
subscribers-only.  We will move it to gnu.org soon to solve that and
other problems but we haven't had time yet.  Sorry for slow response as
well.

> I recently added GnuTLS support to an app, and noticed a slight inconsistancy 
> in the api; one can load certificates, keys and CRLs directly from a file, 
> but there is no corresponding function which takes a filename and loads the 
> DH params from the file. I'm using Debian Testing, which has gnutls13-1.7.19, 
> but I noted that the current online documentation doesn't list a new method 
> to do this either.

Right.

> I have created a trivial patch which implements an api 
> function "gnutls_dh_params_import_pkcs3_file" from a combination 
> of "gnutls_dh_params_import_pkcs3" and "gnutls_certificate_set_x509_crl_file"
>
> I have generated the patch against Debian's gnutls13-1.7.19 source, but 
> appears to apply reasonably to the 2.0.1 source... Otherwise, for easy 
> cut-n-paste, the new method is listed below, along with the corresponding 
> header entry.
>
> If there are any comments or questions, please feel free to let me know.

Your patch looks fine to me.  To be able to install it, we will need a
copyright assignment.  I'll send this off-list to you.

Thanks,
Simon