[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] colors
From: |
Nicolas Roard |
Subject: |
Re: [patch] colors |
Date: |
Sat, 29 May 2004 15:26:20 +0100 |
Le 29 mai 04, à 12:48, Fred Kiefer a écrit :
Hi Nicolas,
sorry for being so slow in patch processing. I am currently doing too
many GNUstep at once, so I don't make any progress on any of them.
The basic idea of this patch is great, but there is one detail we
first should agree on. Up to now the methods in GSDrawFunctions did
not fill the interior of the drawn border, which is one of there big
differences to the normal drawing functions. You changed this for
drawWhiteBezel: to get the cells filled correctly. But if we do it for
this one, shouldn't we be doing it for the rest as well? Or the other
way around, shouldn't we do it here?
Yes, you are right. I wasn't sure about it -- normally, the drawing
functions fills the interior (that's what on openstep description, at
least), so we could argue that the GSDrawFunctions should be
consistent. The thing is that actually we don't need a filling
sometimes (transparent buttons, etc.), and quite often there is a
drawInterior method in the widget code.
As the gui code using GSDrawFunctions work at the moment, I just
modified drawWhiteBezel (which is only used in NSCell/NSCellForm) to
fill, because it seemed sensible at the time ... I'm not so sure now.
Either we want consistency with NSDraw* functions and we modify the
methods to do the filling (possibly with others doing the outline), or
we keep things the way it is (after all, we don't really need the
filling most of the time) and we just add a filling instruction in
NSCell*. We could perhaps keep the code as it is, just renaming the
methods (adding a -Border at the end) in order to be less confusing?
> I could imagine all the GSDrawFunctions methods returning their
interior rectangle and the calling code
> doing any needed filling. Would this be a feasible solution for you?
In that case that's probably a good solution, yes.
Fred
PS: Again, don't expect any quick reply, as I am away for the weekend.
ok :)
--
Nicolas Roard