[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GDL2 - patches for OSX (1)
From: |
David Ayers |
Subject: |
Re: GDL2 - patches for OSX (1) |
Date: |
Tue, 25 Mar 2003 23:30:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210 |
Stéphane Corthésy wrote:
Hi,
I have some patches to help compiling GDL2 on OSX, and which also
correct some bugs. As I have lots of modified files, I'll send them in
small packets.
Great, could you make them diff -u patch files?
Stéphane
Changelog:
EOControl/EODefines.h: new file providing macros for the "extern" clause
Thanks, I've already got that one awaiting checkin...
EOControl/EODeprecated.h: new file declaring some deprecated
methods/classes/symbols; methods/classes/symbols are still implemented
but should no longer be used; they are no longer declared in their
respective header files.
Hmm. ok we should have the file but as those methods are not really
depricated for WO4.5, in fact we'll have to look in from where they
came. I think we should create the file an insert those things that were
depricated for WO4.5 (EOUndoManager, NSObject -flushClassKeyBindings,
EOClassDescription delegate handling and the hint keys. If you know
what the depricated methods do and supply an implementation (I guess
I'll create EODepricated.m file for the above anyway) then we could
consider including them.
EOControl/EOControl.h: added EODeprecated.h, EODefines.h,
EOKeyValueCodingBase.h and EOArrayDataSource.h; removed
EOUndoManager.h (deprecated)
EOControl/EOArrayDataSource.h/m: new files; some methods (<NSCoding>
and qualifier bindings) are empty stubs
---
Index: EOControl.h
===================================================================
RCS file: /cvsroot/gnustep/gnustep/dev-libs/gdl2/EOControl/EOControl.h,v
retrieving revision 1.4
diff -r1.4 EOControl.h
> #import <EOControl/EOKeyValueCodingBase.h>
Why do you need this? I'm looking at obsoleting this file (and it's *.m
counterpart).
---
EOArrayDataSource.m
[snip]
#import "EOArrayDataSource.h"
#import <EOControl/EOClassDescription.h>
#import <EOControl/EOEditingContext.h>
#import <EOControl/EODetailDataSource.h>
Please use #include <EOControl/EOFile.h> consistently.
@implementation EOArrayDataSource
- (id) initWithClassDescription:(EOClassDescription *)classDescription
editingContext:(EOEditingContext *)context
{
// Either argument may be nil
if(self = [self init]){
Please follow the http://www.gnu.org/prep/standards_toc.html and the
existing conventions for GNUstep code.
---
EOArrayDataSource.h
[snip]
#import <EOControl/EODataSource.h>
See above.
I'll look into checking this in soon.
Thanks,
Dave
- GDL2 - patches for OSX (1), Stéphane Corthésy, 2003/03/25
- Re: GDL2 - patches for OSX (1),
David Ayers <=
- Re: GDL2 - patches for OSX (1), David Ayers, 2003/03/25
- Re: GDL2 - patches for OSX (1), Adam Fedor, 2003/03/25
- Re: GDL2 - patches for OSX (1), David Ayers, 2003/03/25
- Re: GDL2 - patches for OSX (1), Nicola Pero, 2003/03/25
- Re: GDL2 - patches for OSX (1), David Ayers, 2003/03/26
- Re: GDL2 - patches for OSX (1), Stéphane Corthésy, 2003/03/26
- Re: GDL2 - patches for OSX (1), David Ayers, 2003/03/26